Apply rector fixes #10305
Merged
Apply rector fixes #10305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e only cases hiding errors when functions called
…hen not validated Fix https://psalm.dev/r/b153d0d248 to return 'a'|null instead of 'a' - this is required as otherwise empty would report RedundantCondition errors now which would bring back vimeo#2681
… more specific type now)
…arisons-on-truthy-falsy-types report error for non-strict or empty comparison on truthy+falsy union
|
I'll merge this now, I'll take it upon myself to do 5.x->master merges in the future now that I have push access (plus, I actually intend to make a first alpha/beta release for v6 soon...) |
|
No dice, windows tests are segfaulting due to yet another PHP bug, damn it... Edit: merged as I'd like to get all potential BC-breaks out of the way in time for the first beta of 6.x, coming hopefully this week, disabled opcache to fix segfaults until php fixes the bug upstream, opened php/php-src#13180 #10564 avoids enabling JIT on windows inside of Psalm itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges 5.x into master and applies some modernization fixes using rector (+ some manual fixes too, mainly involving readonly properties).