Fix return type of DOMXPath::query #10443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can also return namespace nodes, which are not a child class of DOMNode.
orklah
added
the
release:fix
|
Thanks! |
|
@nielsdos Since you are doing a lot of work in DOM. Can you tell me if there is any specific reason why the namespace node is not a DOMNode? Reference : php/php-src#6939 |
I'll reply here for now but let's not disturb this place here too much. You can contact me at my nielsdos at php dot net email address if you want to discuss more in detail. I wasn't there when the decision was made 20 years ago. This is something that I would like to do though and I think it's possible to do. It's just not entirely clear what consequences this could have for the ecosystem (extensions+existing code).
|
tcarrio
pushed a commit
to open-feature/php-sdk
that referenced
this pull request
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | `~5.16.0` -> `~5.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.17.0`](https://togithub.com/vimeo/psalm/releases/tag/5.17.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.16.0...5.17.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Implement by-ref closure use analysis by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10419 ##### Fixes - Update MongoDB stubs for 1.17 by [@​alcaeus](https://togithub.com/alcaeus) in [vimeo/psalm#10402 - Fix backtick analysis by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10409 - Declare we do not support document highlighting by [@​tm1000](https://togithub.com/tm1000) in [vimeo/psalm#10408 - update define types to be correct by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10423 - Fix return type of DOMXPath::query by [@​nielsdos](https://togithub.com/nielsdos) in [vimeo/psalm#10443 - Fix CLI -r error by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10442 - Use correct file path while adding unused suppressions for virtual \__… by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10434 - Restore support for null coalesce on match expressions by [@​tscni](https://togithub.com/tscni) in [vimeo/psalm#10422 - Fix static magic method pureness not being inherited from traits by [@​tscni](https://togithub.com/tscni) in [vimeo/psalm#10429 - Fix POSIX only detection of absolute paths by [@​rarila](https://togithub.com/rarila) in [vimeo/psalm#10441 - Emit UnusedPsalmSuppress issues for suppressed issues already removed by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10431 - Use keyed arrays when assigning literal union keys & assertion fixes by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10439 ##### Internal changes - use branch name to randomize tests to ensure test dependencies will error by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10424 #### New Contributors - [@​nielsdos](https://togithub.com/nielsdos) made their first contribution in [vimeo/psalm#10443 **Full Changelog**: vimeo/psalm@5.16.0...5.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tcarrio
pushed a commit
to open-feature/php-sdk
that referenced
this pull request
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | `~5.16.0` -> `~5.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.17.0`](https://togithub.com/vimeo/psalm/releases/tag/5.17.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.16.0...5.17.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Implement by-ref closure use analysis by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10419 ##### Fixes - Update MongoDB stubs for 1.17 by [@​alcaeus](https://togithub.com/alcaeus) in [vimeo/psalm#10402 - Fix backtick analysis by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10409 - Declare we do not support document highlighting by [@​tm1000](https://togithub.com/tm1000) in [vimeo/psalm#10408 - update define types to be correct by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10423 - Fix return type of DOMXPath::query by [@​nielsdos](https://togithub.com/nielsdos) in [vimeo/psalm#10443 - Fix CLI -r error by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10442 - Use correct file path while adding unused suppressions for virtual \__… by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10434 - Restore support for null coalesce on match expressions by [@​tscni](https://togithub.com/tscni) in [vimeo/psalm#10422 - Fix static magic method pureness not being inherited from traits by [@​tscni](https://togithub.com/tscni) in [vimeo/psalm#10429 - Fix POSIX only detection of absolute paths by [@​rarila](https://togithub.com/rarila) in [vimeo/psalm#10441 - Emit UnusedPsalmSuppress issues for suppressed issues already removed by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10431 - Use keyed arrays when assigning literal union keys & assertion fixes by [@​danog](https://togithub.com/danog) in [vimeo/psalm#10439 ##### Internal changes - use branch name to randomize tests to ensure test dependencies will error by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10424 #### New Contributors - [@​nielsdos](https://togithub.com/nielsdos) made their first contribution in [vimeo/psalm#10443 **Full Changelog**: vimeo/psalm@5.16.0...5.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
](https://renovatebot.com){kind=link}
|
I tried adding this change into phpstan, which sparked some interessing questions: phpstan/phpstan-src#2842 (comment) @nielsdos do you have concrete "real world" code examples for which this change is necessary/useful? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can also return namespace nodes, which are not a child class of DOMNode.