Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report error for non-strict or empty comparison on truthy+falsy union #10502

Merged
merged 12 commits into from
Jan 17, 2024
Merged

report error for non-strict or empty comparison on truthy+falsy union #10502

merged 12 commits into from
Jan 17, 2024

Commits on Jan 15, 2024

  1. Fix vimeo#10501 - report error for non-strict comparison on truthy+fa… 

    …lsy union
    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d5b713e View commit details
    Browse the repository at this point in the history

  2. add the fix for empty() too and fix empty returning bool on true/fals… 

    …e only cases hiding errors when functions called
    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f3543ca View commit details
    Browse the repository at this point in the history

  3. create a separate issue type

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    fb93aed View commit details
    Browse the repository at this point in the history

  4. fix shepherd issue

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    63ea734 View commit details
    Browse the repository at this point in the history

  5. fix possibly undefined array key in keyed array doesnt include null w… 

    …hen not validated

Fix https://psalm.dev/r/b153d0d248 to return 'a'|null instead of 'a' - this is required as otherwise empty would report RedundantCondition errors now which would bring back vimeo#2681
    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    19b1a33 View commit details
    Browse the repository at this point in the history

  6. fix bugs in tests

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    93dc221 View commit details
    Browse the repository at this point in the history

  7. unrelated fix spelling

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    dca17bc View commit details
    Browse the repository at this point in the history

  8. simplify and remove redundant variable

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2414070 View commit details
    Browse the repository at this point in the history

  9. fix mixed test not actually checking mixed (since superglobals have a… 

    … more specific type now)
    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5643cf5 View commit details
    Browse the repository at this point in the history

  10. change error level to 2

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    f34ec2c View commit details
    Browse the repository at this point in the history

  11. update baseline

    @kkmuffme
    kkmuffme committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4b41891 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. fix baseline somehow incorrect paths

    @kkmuffme
    kkmuffme committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a3a1324 View commit details
    Browse the repository at this point in the history