Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve string-int juggle consistency in array keys and display for int-like strings in type #10814

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Improve string-int juggle consistency in array keys and display for int-like strings in type #10814

merged 5 commits into from
Mar 23, 2024

Commits on Mar 22, 2024

  1. add tests for int-like string array keys

    @kkmuffme
    kkmuffme committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1b91f56 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @kkmuffme
    kkmuffme committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    120e312 View commit details
    Browse the repository at this point in the history

  3. separate fix of vimeo#10481 to a reusable function

    @kkmuffme
    kkmuffme committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6030995 View commit details
    Browse the repository at this point in the history

  4. further improve string-int juggling handling which was previously alr… 

    …eady improved by me in vimeo#10481

Also fix https://psalm.dev/r/3b401c6f88
    @kkmuffme
    kkmuffme committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    cd302f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. scientific and underscore notation should be quoted too, since they w… 

    …on't be type juggled
    @kkmuffme
    kkmuffme committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    1bfa684 View commit details
    Browse the repository at this point in the history