Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update master from 5.x #10850

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Update master from 5.x #10850

wants to merge 49 commits into from

Commits on Mar 9, 2024

  1. Use wider class-string when combining class strings with intersections 

    Fixes vimeo#10799
    @weirdan
    weirdan committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    739d87d View commit details
    Browse the repository at this point in the history

  2. Merge pull request vimeo#10800 from weirdan/10799-use-wider-classstring

    @weirdan
    weirdan committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    005e318 View commit details
    Browse the repository at this point in the history

  3. Forbid named arguments for ArrayAcccess methods 

    Fixes vimeo#10533
    @weirdan
    weirdan committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    00c2fef View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Merge pull request vimeo#10804 from weirdan/10533-no-named-arguments-… 

    …for-array-access
    @weirdan
    weirdan committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    c511185 View commit details
    Browse the repository at this point in the history

  2. Allow more callable types as subtypes of callable 

    Fixes vimeo#10461
    @weirdan
    weirdan committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    20c7889 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Don't crash on invalid templates 

    Fixes vimeo#9596
    @weirdan
    weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4a2cf93 View commit details
    Browse the repository at this point in the history

  2. Merge pull request vimeo#10806 from weirdan/9596-dont-crash-on-invali… 

    …d-templates
    @weirdan
    weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ae1d510 View commit details
    Browse the repository at this point in the history

  3. Added test for vimeo#10807

    @SCIF @weirdan
    SCIF authored and weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2a91bd6 View commit details
    Browse the repository at this point in the history

  4. Resolve fail test vimeo#10807 

    Resolved problem:
```
Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork
Psalm\Exception\CodeException: LessSpecificReturnStatement
The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty
```
    @issidorov @weirdan
    issidorov authored and weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    fe42e88 View commit details
    Browse the repository at this point in the history

  5. Merge pull request vimeo#10812 from issidorov/bug-10807

    @weirdan
    weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8471a89 View commit details
    Browse the repository at this point in the history

  6. Merge branch '5.23.x' into 5.x

    @weirdan
    weirdan committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4ea41cb View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Introduce TCallableInterface 

    `TClosure` does not implement it at this point. It's intentional, to maintain the
separation between callables and closures that our code relies on.
    @weirdan
    weirdan committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c9468b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. add support for named arguments for filter_var and filter_input 

    this fixes vimeo#10809
    @pilif
    pilif committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    debffec View commit details
    Browse the repository at this point in the history

  2. Promoted properties missing in extended __construct should report Pro… 

    …pertyNotSetInConstructor

Fix vimeo#10786
    @kkmuffme
    kkmuffme committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9c5af0f View commit details
    Browse the repository at this point in the history

  3. report error for single param too since named args can even be used then

    @kkmuffme
    kkmuffme committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a2307ac View commit details
    Browse the repository at this point in the history

  4. Fix vimeo#7550

    @kkmuffme
    kkmuffme committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c174e35 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. MissingClassConstType

    @jack-worman
    jack-worman committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c7fc76e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Allow specifying flags to Codebase::isTypeContainedByType

    @danog
    danog committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ad87c2e View commit details
    Browse the repository at this point in the history

  2. cs-fix

    @danog
    danog committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b431e5f View commit details
    Browse the repository at this point in the history

  3. [PHP 8.4] Fixes for implicit nullability deprecation 

    Fixes all issues that emits a deprecation notice on PHP 8.4.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
    @Ayesh
    Ayesh committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    431977c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Fix undefined parent not reported in callable 

    Fix vimeo#10836
    @kkmuffme
    kkmuffme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    ff168a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. fix tests running with other than called PHP binary if called with a … 

    …non-default PHP binary

e.g. you run the tests with a php83 executable but your default php is PHP 7.4, it will suddenly change while running the tests leading to false positive errors
    @kkmuffme
    kkmuffme committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8815463 View commit details
    Browse the repository at this point in the history

  2. Merge pull request vimeo#10842 from kkmuffme/fix-tests-using-other-th… 

    …an-called-from-php-version

fix tests running with other than called PHP binary if called with a non-default PHP binary
    @danog
    danog committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e8e1f47 View commit details
    Browse the repository at this point in the history

  3. Explicitly set value in config to fix warning in tests

    @kkmuffme
    kkmuffme committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ea825c6 View commit details
    Browse the repository at this point in the history

  4. fix bad class

    @kkmuffme
    kkmuffme committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8efbf38 View commit details
    Browse the repository at this point in the history

  5. Merge pull request vimeo#10843 from kkmuffme/fix-psalm-6-notice-in-te… 

    …sts-config

Explicitly set value in config to fix warning in tests
    @danog
    danog committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    45d9fbe View commit details
    Browse the repository at this point in the history

  6. Merge pull request vimeo#10832 from Ayesh/php84/nullability

    @weirdan
    weirdan committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    644ef8d View commit details
    Browse the repository at this point in the history

  7. Merge pull request vimeo#10829 from vimeo/isTypeContainedByType_flags

    @weirdan
    weirdan committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4b7957b View commit details
    Browse the repository at this point in the history

  8. Merge pull request vimeo#10805 from weirdan/10461-allow-more-callable… 

    …-types-as-subtypes-of-callable
    @weirdan
    weirdan committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f61c7e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. self, parent and static in callable are deprecated since PHP 8.2 

    Fix vimeo#10837
    @kkmuffme @weirdan
    kkmuffme authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a59248f View commit details
    Browse the repository at this point in the history

  2. report invalid callable if callable cannot be called like this from c… 

    …urrent context

Fix vimeo#10823
Fix vimeo#8509
    @kkmuffme @weirdan
    kkmuffme authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e83530a View commit details
    Browse the repository at this point in the history

  3. Merge pull request vimeo#10838 from kkmuffme/undefined-parent-not-rep… 

    …orted-in-callable
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e3d5526 View commit details
    Browse the repository at this point in the history

  4. Merge pull request vimeo#10824 from kkmuffme/update-misc-deprecated-a… 

    …rg-types-PHP81-83
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c5adc51 View commit details
    Browse the repository at this point in the history

  5. Merge pull request vimeo#10822 from kkmuffme/report-param-name-mismat… 

    …ch-for-single-param-too
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    98eab1f View commit details
    Browse the repository at this point in the history

  6. Merge pull request vimeo#10815 from pilif/filter_var-named-args

    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2c1ac98 View commit details
    Browse the repository at this point in the history

  7. Merge pull request vimeo#10828 from jack-worman/MissingClassConstType

    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3a1b10f View commit details
    Browse the repository at this point in the history

  8. ParamNameMismatch not reported for __construct 

    Fix vimeo#10784
    @kkmuffme @weirdan
    kkmuffme authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9cfce37 View commit details
    Browse the repository at this point in the history

  9. Merge pull request vimeo#10821 from kkmuffme/consistent-constructor-p… 

    …aram-name-mismatch
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    cc5ad67 View commit details
    Browse the repository at this point in the history

  10. When inside isset, array fetch can return null 

    This prevents false positive for various types of issues inside empty,
such as RedundantConditionGivenDocblockType and TypeDoesNotContainType.
    @edsrzf @weirdan
    edsrzf authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    86173d2 View commit details
    Browse the repository at this point in the history

  11. Update baseline

    @edsrzf @weirdan
    edsrzf authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    30e797b View commit details
    Browse the repository at this point in the history

  12. Additional array fetch test case

    @edsrzf @weirdan
    edsrzf authored and weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4b707d1 View commit details
    Browse the repository at this point in the history

  13. Merge pull request vimeo#10756 from edsrzf/array-isset

    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    70530d6 View commit details
    Browse the repository at this point in the history

  14. Merge pull request vimeo#10817 from kkmuffme/promoted-properties-not-… 

    …set-in-extended-constructor
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b47449f View commit details
    Browse the repository at this point in the history

  15. Update tests/CallableTest.php

    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    375fe32 View commit details
    Browse the repository at this point in the history

  16. Merge pull request vimeo#10839 from kkmuffme/misc-class-callable-erro… 

    …rs-not-reported
    @weirdan
    weirdan committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4266a8e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Update CallMap.php

    @ThomasLandauer
    ThomasLandauer committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2f90881 View commit details
    Browse the repository at this point in the history

  2. Update CallMap_historical.php

    @ThomasLandauer
    ThomasLandauer committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2ae91aa View commit details
    Browse the repository at this point in the history

  3. Merge pull request vimeo#10847 from ThomasLandauer/patch-1

    @weirdan
    weirdan committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    63ea4de View commit details
    Browse the repository at this point in the history

  4. Merge branch '5.x' into update-master

    @weirdan
    weirdan committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2aed495 View commit details
    Browse the repository at this point in the history