add function and consistent error for internal property #10867

kkmuffme · 2024-03-28T00:56:01Z

Fix @psalm-internal does not emit errors consistently #10025
Fix examples from @psalm-internal does not emit errors consistently #10025 (comment)
Feature: allow functions to use @internal annotations too
Feature: treat legacy PHP @access private annotations as @internal annotations
Fix global namespace @internal methods should be treated as internal to the class, just like properties are already
Fix non-namespaced @internal annotations should disallow use outside of global namespace #10868

kkmuffme · 2024-03-28T02:06:05Z

Ready to review & merge

…` annotations

…ties and fix vimeo#10868

kkmuffme · 2024-05-03T14:14:14Z

@orklah would you be so kind to review & merge this please?

kkmuffme force-pushed the add-some-missing-internal-errors branch 4 times, most recently from ff0fd62 to 069afde Compare March 28, 2024 01:59

kkmuffme added 3 commits March 28, 2024 03:05

add function and consistent error for internal property

efd17a1

same for classes and class constants

086cc08

Fix vimeo#10025

add support for @internal in functions

032edd9

kkmuffme force-pushed the add-some-missing-internal-errors branch from 069afde to 032edd9 Compare March 28, 2024 02:05

kkmuffme marked this pull request as ready for review March 28, 2024 02:05

Feature: treat legacy PHP @access private annotations as `@internal…

21c0066

…` annotations

kkmuffme force-pushed the add-some-missing-internal-errors branch from 6d06246 to 616237a Compare March 29, 2024 00:17

Make @internal in global namespace for methods consistent with proper…

5ed0103

…ties and fix vimeo#10868

kkmuffme force-pushed the add-some-missing-internal-errors branch from 616237a to 5ed0103 Compare March 29, 2024 00:22

Provide feedback