Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for allowPhpstormGenerics #6705

Merged
merged 2 commits into from Jan 3, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Oct 20, 2021

One of the BC breaks for Psalm 5

@muglug
Copy link
Collaborator

muglug commented Oct 24, 2021

So happy to see this deprecation!

@orklah
Copy link
Collaborator Author

orklah commented Oct 25, 2021

my preffered standard phpdoc way of specifying array types

Are you sure you're talking about the same thing?

What is being deprecated here it Collection|array<int> being interpreted by Psalm as a Collection<int>. Can you give us an example of what you think you have to replace?

@orklah orklah added the release:removed The PR will be included in 'Removed' section of the release notes label Nov 3, 2021
@orklah orklah added this to the Psalm 5 milestone Dec 23, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jan 2, 2022

@orklah is this ready?

@orklah
Copy link
Collaborator Author

orklah commented Jan 2, 2022

Yeah, it can be merged, I was just waiting for the new major branch :)

@weirdan weirdan marked this pull request as ready for review January 2, 2022 13:53
@weirdan weirdan merged commit f19e4ce into vimeo:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:removed The PR will be included in 'Removed' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants