Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❗Allow plugins to modify Config::$fileExtensions early #6789

Merged
merged 2 commits into from Jan 30, 2022
Merged

❗Allow plugins to modify Config::$fileExtensions early #6789

merged 2 commits into from Jan 30, 2022

Commits on Jan 30, 2022

  1. !!! Allow plugins to modify Config::$fileExtensions early 

    ProjectAnalyzer consumed Config::$fileExtensions early in its
constructor - without having processed plugins' modifications,
registering their custom scanners or analyzer implementations.

This change
* adds new specific interface \Psalm\Plugin\FileExtensionsInterface
  to be used by plugin implementations
* extracts file extension handling from \Psalm\PluginRegistrationSocket
  and interface \Psalm\Plugin\RegistrationInterface to a new dedicated
  \Psalm\PluginFileExtensionsSocket and new interface
  \Psalm\Plugin\FileExtensionsInterface
  !!! this is a breaking change in PluginRegistrationSocket !!!
* adds runtime in-memory cache for Config::$plugins
* calls new method Config::processPluginFileExtensions(), providing
  modifications to file extension only early in ProjectAnalyzer
* adjusts documentation
    @ohader
    ohader committed Jan 30, 2022
    Copy the full SHA
    62a0ece View commit details
    Browse the repository at this point in the history

  2. Apply code styles

    @ohader
    ohader committed Jan 30, 2022
    Copy the full SHA
    3fedb5c View commit details
    Browse the repository at this point in the history