Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parser cache files maintenance #7082

Merged
merged 6 commits into from Dec 11, 2021

Conversation

dvz
Copy link
Contributor

@dvz dvz commented Dec 6, 2021

Resolves #7061

@@ -1074,6 +1068,7 @@ private function checkDirWithConfig(string $dir_name, Config $config, bool $allo

/**
* @return list<string>
* @deprecated going to be removed in Psalm 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private function of an internal class may be removed right away.

Comment on lines 353 to 355
* @deprecated going to be removed in Psalm 5
*/
public function processSuccessfulRun(): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't require deprecation period either.

Comment on lines 382 to 384
* @deprecated going to be removed in Psalm 5
*/
public function touchParserCaches(array $file_names, int $min_time): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Dec 11, 2021
@orklah
Copy link
Collaborator

orklah commented Dec 11, 2021

Thanks!

@orklah orklah merged commit b663841 into vimeo:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suboptimal maintenance of parser cache files using touch()
3 participants