Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stub parent class not loaded. #7110

Merged
merged 7 commits into from Jan 22, 2022
+346 −265
Merged

Fix stub parent class not loaded. #7110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f2c24c
Add reproducer for stub parent class not being loaded.
AndrolGenhald Dec 9, 2021
db67d2c
Add support for checking parent classes and interfaces from stubs.
AndrolGenhald Dec 9, 2021
c24cf9a
Add test for circular reference with stub class.
AndrolGenhald Dec 9, 2021
2262cb6
Check for circular references with stubbed classes.
AndrolGenhald Dec 9, 2021
9a064c0
Fix invalid trailing comma.
AndrolGenhald Dec 9, 2021
3510f55
Check for indirect circular dependencies with stubbed parents.
AndrolGenhald Dec 14, 2021
0c142ee
Add BC break note.
AndrolGenhald Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADING.md
View file
Open in desktop
Expand Up @@ -120,6 +120,7 @@
- [BC] Method `Psalm\Type\Union::isFormerStaticObject()` was renamed to `isStaticObject()`
- [BC] Method `Psalm\Type\Union::hasFormerStaticObject()` was renamed to `hasStaticObject()`
- [BC] Function assertions (from `@psalm-assert Foo $bar`) have been converted from strings to specific `Assertion` objects.
- [BC] Property `Psalm\Storage\ClassLikeStorage::$invalid_dependencies` changed from `array<string>` to `array<string, true>`.

## Removed
- [BC] Property `Psalm\Codebase::$php_major_version` was removed, use
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Internal/Analyzer/ClassLikeAnalyzer.php
View file
Open in desktop
Expand Up @@ -336,7 +336,7 @@ public static function checkFullyQualifiedClassLikeName(
return null;
}

foreach ($class_storage->invalid_dependencies as $dependency_class_name) {
foreach ($class_storage->invalid_dependencies as $dependency_class_name => $_) {
// if the implemented/extended class is stubbed, it may not yet have
// been hydrated
if ($codebase->classlike_storage_provider->has($dependency_class_name)) {
Expand Down