Require @internal annotation on Psalm\Internal symbols
#7268
+640
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
the
release:internal
weirdan
force-pushed
the
internal-is-internal
branch
from
915a5a3 to
d3c4f96
Compare
weirdan
force-pushed
the
internal-is-internal
branch
from
f5abd13 to
2066a21
Compare
orklah
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Roave/BackwardCompatibilityCheck#382
This PR adds a plugin that enforces that all classlikes under
Psalm\Internalnamespace are marked@internal. The plugin also acts as a fixer (when it's used withpsalter).