Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped deprecated CodeIssue methods #7276

Merged
merged 2 commits into from Jan 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions UPGRADING.md
Expand Up @@ -152,3 +152,6 @@
- `Psalm\Plugin\Hook\AfterClassLikeAnalysisInterface`
- `Psalm\Plugin\Hook\PropertyVisibilityProviderInterface`
- `Psalm\Plugin\Hook\AfterStatementAnalysisInterface`
- [BC] Method `Psalm\Issue\CodeIssue::getLocation()` was removed
- [BC] Method `Psalm\Issue\CodeIssue::getFileName()` was removed
- [BC] Method `Psalm\Issue\CodeIssue::getMessage()` was removed
27 changes: 0 additions & 27 deletions src/Psalm/Issue/CodeIssue.php
Expand Up @@ -38,15 +38,6 @@ public function __construct(
$this->message = $message;
}

/**
* @deprecated going to be removed in Psalm 5
* @psalm-suppress PossiblyUnusedMethod
*/
public function getLocation(): CodeLocation
{
return $this->code_location;
}

public function getShortLocationWithPrevious(): string
{
$previous_text = '';
Expand All @@ -69,24 +60,6 @@ public function getFilePath(): string
return $this->code_location->file_path;
}

/**
* @deprecated going to be removed in Psalm 5
* @psalm-suppress PossiblyUnusedMethod for convenience
*/
public function getFileName(): string
{
return $this->code_location->file_name;
}

/**
* @deprecated going to be removed in Psalm 5
* @psalm-suppress PossiblyUnusedMethod
*/
public function getMessage(): string
{
return $this->message;
}

public static function getIssueType(): string
{
$fqcn_parts = explode('\\', static::class);
Expand Down