Apply literal number separator rector #7299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I opted for customary 3-digit groups, except version id, where 2-digit groups are used to match the version id encoding.
weirdan
commented
Jan 4, 2022
weirdan
added
the
release:internal
|
It it possible to add this to the CS check so we ensure it stays consistent going forward? |
|
Not with the different grouping for version id. I find this difference quite useful, though. |
|
On the second thought, we can mandate at least one separator for values exceeding 1000 without specifying where it should be placed. |
I would like to set minDigitsBeforeDecimalPoint to 4, but it causes false positives with octal numbers (slevomat/coding-standard#1324).
orklah
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted for customary 3-digit groups, except version id, where 2-digit groups match the version id encoding.