Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied ClosureToArrowFunctionRector #7315

Merged
merged 2 commits into from Jan 6, 2022
Merged

Applied ClosureToArrowFunctionRector #7315

merged 2 commits into from Jan 6, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jan 5, 2022 •
edited

Finally down to the fun one

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 5, 2022
@weirdan weirdan added this to the Psalm 5 milestone Jan 5, 2022
@weirdan weirdan requested a review from orklah January 5, 2022 22:48
@orklah
Copy link
Collaborator

orklah commented Jan 5, 2022

That seems to work well :)

Did you have to make changes by hand after rector?

@weirdan
Copy link
Collaborator Author

weirdan commented Jan 5, 2022

Did you have to make changes by hand after rector?

I did some minor editing: restored one docblock, fixed lines exceeding 120 characters and reformatted a couple of functions.

@weirdan weirdan merged commit b6559dc into vimeo:master Jan 6, 2022
@weirdan weirdan deleted the rector-ClosureToArrowFunctionRector branch January 6, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
Psalm 5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weirdan @orklah