Applied ArraySpreadInsteadOfArrayMergeRector #7319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
the
release:internal
|
Oh, I didn't jnow that one. Do we know if there's performance considerations here? |
|
From my testing, it seems the function call is slightly slower. I ran $ time php-noxdebug vendor/bin/phpunit --repeat=10 tests/Internal/CallMapTest.php
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.
Runtime: PHP 8.1.1-dev
Configuration: /home/weirdan/src/psalm/psalm/phpunit.xml
Random Seed: 1641442685
............................................................... 63 / 150 ( 42%)
............................................................... 126 / 150 ( 84%)
........................ 150 / 150 (100%)
Time: 03:05.184, Memory: 72.00 MB
OK (150 tests, 1575360 assertions)
user=185.23s system=0.13s cpu=99% total=3:05.38
$ git co rector-ArraySpreadInsteadOfArrayMergeRector
M composer.json
Switched to branch 'rector-ArraySpreadInsteadOfArrayMergeRector'
$ php-noxdebug vendor/bin/phpunit --repeat=10 tests/Internal/CallMapTest.php
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.
Runtime: PHP 8.1.1-dev
Configuration: /home/weirdan/src/psalm/psalm/phpunit.xml
Random Seed: 1641442981
............................................................... 63 / 150 ( 42%)
............................................................... 126 / 150 ( 84%)
........................ 150 / 150 (100%)
Time: 03:01.241, Memory: 70.00 MB
OK (150 tests, 1575360 assertions)
user=181.31s system=0.12s cpu=99% total=3:01.45The difference seems to be ~3% in this case, but I can't say how representative is that. |
|
It's at least an indication of non-worsening so that's fine by me :) |
orklah
approved these changes
Jan 6, 2022
|
@weirdan this should not be blocked anymore if you have time to rebase it |
|
Superseded by #8345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #7296