Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify object comparison #7340

Merged
merged 1 commit into from Jan 8, 2022
Merged

Conversation

muglug
Copy link
Collaborator

@muglug muglug commented Jan 7, 2022

The original ObjectComparator code was quite hard to follow. This attempts to make it more clear, fixing a bug or two along the way.

@muglug muglug added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 7, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 8, 2022

Cool! Thanks!

@orklah orklah merged commit b941078 into master Jan 8, 2022
@muglug muglug deleted the muglug-simplify-object-comparison branch January 15, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants