fix: pass static class name to ReturnTypeAnalyzer #7366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already stated out in PR #7359 and found there:
In these lines the
$fq_classlike_name
is overriden if the return type is declared in a parent class:psalm/src/Psalm/Internal/Analyzer/ClassAnalyzer.php
Lines 1871 to 1875 in 549c02d
And then downpassed via
ReturnTypeAnalyzer::verifyReturnType
to as both$self_class
- and$static_class_type
-param.psalm/src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeAnalyzer.php
Lines 424 to 428 in 549c02d
The bug is currently not really visible, as e.g. for
@return class-string<static>
correctly onlystatic::class
is allowed and therefor not expected.