New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that all entries in test arrays have explicit keys #7386
Conversation
[], | ||
[ | ||
'assertions' => [], | ||
'ignored_issues' => [ | ||
'InvalidDocblock' => Config::REPORT_INFO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does having a report option does here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I recall it was an edge-case where this slight suppression was necessary to trigger a bug
'error_levels' => [], | ||
'strict_mode' => true, | ||
], | ||
'concatenationWithNumberInStrictMode' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was moved up into a custom section to remove the strict_mode
argument from the trait signature
This PR serves two purposes:
Obviously the second point doesn't benefit Psalm in any way, and if you feel the code change is an annoyance feel free to disregard this.