Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make key-of/value-of usable with non-const arrays #7396

Merged
merged 11 commits into from Jan 31, 2022
Merged

feat: make key-of/value-of usable with non-const arrays #7396

merged 11 commits into from Jan 31, 2022

Commits on Jan 27, 2022

  1. feat: make key-of/value-of usable with non-const arrays

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    2880d04 View commit details
    Browse the repository at this point in the history

  2. feat: allow unions for key-of/value-of 

    Add tests for TValueOfArray.
    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    1f28d02 View commit details
    Browse the repository at this point in the history

  3. tests: correct 'SKIPPED' prefix for skipped test

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    ed87465 View commit details
    Browse the repository at this point in the history

  4. style: add use statement for array_push

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    8f0244a View commit details
    Browse the repository at this point in the history

  5. style: remove unused variable declaration

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    ce1feb1 View commit details
    Browse the repository at this point in the history

  6. style: remove unused use statement

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    dff8869 View commit details
    Browse the repository at this point in the history

  7. feat: make value-of<T> capable for template types

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    8cd5ccd View commit details
    Browse the repository at this point in the history

  8. fix: infer key-of/value-of type if still templated 

    Not in all cases the TemplateParam gets replaced before type checking,
in these cases, use the defined `as` type.
Refactor to extract key/value type of array union to method.
    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    f87e429 View commit details
    Browse the repository at this point in the history

  9. fix: key-of/value-of handle nested template params

    @Patrick-Remy
    Patrick-Remy committed Jan 27, 2022
    Copy the full SHA
    51cab70 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. fix: replace template args in key-of/value-of 

    Extend TTemplateKeyOf from Atomic instead of Scalar, to ensure it is
only compared in AtomicTypeComparator to reduce duplicate code.
    @Patrick-Remy
    Patrick-Remy committed Jan 31, 2022
    Copy the full SHA
    51d4bf5 View commit details
    Browse the repository at this point in the history

  2. docs: add key-of/value-of BC to UPGRADING

    @Patrick-Remy
    Patrick-Remy committed Jan 31, 2022
    Copy the full SHA
    f480eb2 View commit details
    Browse the repository at this point in the history