feat: Handle native intersection types

[petewalker]

I've raised this against 4.x, but not sure if it's for 4.x or master?

Adds native intersection type handling to psalm, removing the previous UnexpectedValueException.

Where an intersection is found in the parse tree, the types are resolved using the existing Type::intersectUnionTypes function, which I assume is being used when they're encountered in the existing docblock annotations.

I've added a handful of tests to cover this, but they're certainly not exhaustive. Are there any specific edge cases I should target?

This change feels way too simple... so apologies if I've missed something fundamental..!

Resolves #6413

[AndrolGenhald]

I would add a test to make sure A&(B|C) is never allowed in PHP type signatures, it probably already works correctly but we definitely want to catch that and make sure it doesn't break in the future. Also add a test to make sure A&B is caught for PHP < 8.1 (looks like that one might need tweaking to make it work).

[petewalker]

I would add a test to make sure A&(B|C) is never allowed in PHP type signatures, it probably already works correctly but we definitely want to catch that and make sure it doesn't break in the future.

👍 This triggers a ParseError currently anyway

Also add a test to make sure A&B is caught for PHP < 8.1 (looks like that one might need tweaking to make it work).

I can try to do this, but there doesn't seem to be a similar rule for A|B in PHP < 8.0? What should do psalm throw in these cases?

[orklah]

Please target on master, We try to target new features on master to avoid future maintenance on old branches.

[petewalker]

I've retargeted to master and added some extra checks for unions in PHP < 8.0 and intersections in PHP < 8.1.

It's meant allowing TypeHintResolver to raise issues to the IssueBuffer. I'm not sure if that's desirable or not..!

[AndrolGenhald]

I can try to do this, but there doesn't seem to be a similar rule for A|B in PHP < 8.0? What should do psalm throw in these cases?

Well that's not great.

...added some extra checks for unions in PHP < 8.0 and intersections in PHP < 8.1

That'll be good to have! Looks like it needs to exclude stubs and ignored files somehow though.

[petewalker]

Woops... well, that broke a lot of stuff - more to do..!

[AndrolGenhald]

@petewalker Try IssueBuffer::maybeAdd, that might solve it. I'm not really sure that IssueBuffer::add should be used hardly anywhere, we might want to look over current uses of it at some point and make sure they're not supposed to be suppressible.

[petewalker]

@orklah @AndrolGenhald - I think it's all good to go now

[petewalker]

I'm not sure that failing test has anything to do with my change? Unless I'm missing something.

[orklah]

Thanks! That looks great!