Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! Deprecate \Psalm\Plugin\RegistrationInterface methods #7455

Merged
merged 2 commits into from
Jan 22, 2022

Conversation

ohader
Copy link
Contributor

@ohader ohader commented Jan 21, 2022

Following \Psalm\Plugin\RegistrationInterface methods are deprecated

  • addFileTypeScanner
  • addFileTypeAnalyzer

Following \Psalm\PluginRegistrationSocket methods are deprecated

  • addFileTypeScanner
  • getAdditionalFileTypeScanners
  • addFileTypeAnalyzer
  • getAdditionalFileTypeAnalyzers
  • getAdditionalFileExtensions
  • addFileExtension

Mentioned methods will be removed in Psalm v5.0, corresponding
functionality will be provided by following new interfaces and classes

  • \Psalm\Plugin\FileExtensionsInterface
  • \Psalm\PluginFileExtensionsSocket

Related: #6788

Following \Psalm\Plugin\RegistrationInterface methods are deprecated
+ addFileTypeScanner
+ addFileTypeAnalyzer

Following \Psalm\PluginRegistrationSocket methods are deprecated
+ addFileTypeScanner
+ getAdditionalFileTypeScanners
+ addFileTypeAnalyzer
+ getAdditionalFileTypeAnalyzers
+ getAdditionalFileExtensions
+ addFileExtension

Mentioned methods will be removed in Psalm v5.0, corresponding
functionality will be provided by following new interfaces and classes
+ \Psalm\Plugin\FileExtensionsInterface
+ \Psalm\PluginFileExtensionsSocket

Related: vimeo#6788
@orklah
Copy link
Collaborator

orklah commented Jan 21, 2022

Please add deprecations in the baseline. Once this will be merged, we'll remove the methods on master and refresh the baseline again

@ohader
Copy link
Contributor Author

ohader commented Jan 21, 2022

Please add deprecations in the baseline. Once this will be merged, we'll remove the methods on master and refresh the baseline again

I'd love to do that. However, I have absolutely no idea what to do and how to reference these things in paslm-baseline.xml... I tried to add DeprecatedMethod sections - however running psalm --use-baseline=psalm-baseline.xml with and without these changes did not make any differences.

@ohader
Copy link
Contributor Author

ohader commented Jan 21, 2022

30 min trial-and-error and it seems to work... cad7200

@orklah
Copy link
Collaborator

orklah commented Jan 21, 2022

sorry, couldn't reply sooner. --set-baseline=psalm-baseline.xml regenerate the baseline entirely

@orklah orklah merged commit 0bf3c43 into vimeo:4.x Jan 22, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 22, 2022

Thanks!

@ohader ohader deleted the issue-6788-4x branch January 22, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants