Fix crash due to unresolvable constant. #7490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I forgot trailing commas are still disallowed in argument lists until PHP 8.0 🙁 |
|
Actually maybe it'd be better to pass an optional |
orklah
added
the
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7123 introduced a crash whenever the new
UnresolvableConstantissue is supposed to be added. It wasn't caught by tests because the tests end as soon as the first issue is raised, and the issue is raised before it crashes.Not the prettiest fix, but at least it works. I'm not super happy with it, but I can't think of a better way at the moment.