Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock event classes #7491

Merged
merged 2 commits into from Jan 26, 2022
Merged

Lock event classes #7491

merged 2 commits into from Jan 26, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jan 26, 2022

This makes all event (Psalm\Plugin\EventHandler\Event\*) classes final, allowing us to add methods to them without breaking BC.

Additionally, all constructors of those classes are made @internal as plugins are not supposed to emit events.

This makes all event (`Psalm\Plugin\EventHandler\Event\*`) classes
`final`, allowing us to add methods to them without breaking BC.

Additionally all constructors of those classes are made `@internal` as
plugins are not supposed to emit events.
@weirdan weirdan added release:removed The PR will be included in 'Removed' section of the release notes PR: Need review labels Jan 26, 2022
@weirdan weirdan added this to the Psalm 5 milestone Jan 26, 2022
@weirdan weirdan requested a review from orklah January 26, 2022 00:28
@weirdan weirdan merged commit bf22dcf into vimeo:master Jan 26, 2022
@weirdan weirdan deleted the lock-event-classes branch January 26, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:removed The PR will be included in 'Removed' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants