Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all template parameters are specified in all extended|used classlikes #7492

Merged
merged 6 commits into from Jan 31, 2022

Conversation

danog
Copy link
Collaborator

@danog danog commented Jan 26, 2022

For feature parity with phpstan.

This PR kind of renders useless the template_extended_count property, replacing it with the more complete template_type_extends_count, IDK if it's worth deprecating here and removing in v5.

@danog danog changed the title Ensure all template parameters are specified in all classlikes Ensure all template parameters are specified in all extended|used classlikes Jan 26, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 26, 2022

Please target this on master. This is too big of a change to enforce in all project on 4.x

But this is great however, I wonder if it would be hard to add for arrays too?

And yeah, please deprecate the property on 4.x still, that way it can be removed on master

@orklah orklah added PR: Needs work release:feature The PR will be included in 'Features' section of the release notes labels Jan 26, 2022
@danog danog changed the base branch from 4.x to master January 26, 2022 17:50
@orklah
Copy link
Collaborator

orklah commented Jan 26, 2022

I have a merge up to do before you can retrieve your changes from 4.x. I'll do that shortly

@orklah
Copy link
Collaborator

orklah commented Jan 26, 2022

I made the merge

@danog
Copy link
Collaborator Author

danog commented Jan 26, 2022

Rebased!

@orklah
Copy link
Collaborator

orklah commented Jan 26, 2022

Rebasing seem to toggle the colors of your user profile image 😄

@danog
Copy link
Collaborator Author

danog commented Jan 26, 2022

Rebasing seem to toggle the colors of your user profile image 😄

The original profile picture was transparent and broke dark mode, I was waiting for someone @github to notice that transparent pictures may break with themes, unfortunately they didn't, so I had to revert :( 😊

@orklah
Copy link
Collaborator

orklah commented Jan 27, 2022

@weirdan Can I let you merge that and update phpunit's baseline?

@weirdan
Copy link
Collaborator

weirdan commented Jan 30, 2022

@danog please rebase. I don't seem to be able to push to your branch:

$ git push --force-with-lease
ERROR: Permission to zoonru/psalm.git denied to weirdan.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@danog
Copy link
Collaborator Author

danog commented Jan 31, 2022

Done!

@weirdan weirdan merged commit 958e3cc into vimeo:master Jan 31, 2022
@weirdan
Copy link
Collaborator

weirdan commented Jan 31, 2022

Thanks!

@weirdan weirdan mentioned this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Need review release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants