-
Notifications
You must be signed in to change notification settings - Fork 680
Ensure all template parameters are specified in all extended|used classlikes #7492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please target this on master. This is too big of a change to enforce in all project on 4.x But this is great however, I wonder if it would be hard to add for arrays too? And yeah, please deprecate the property on 4.x still, that way it can be removed on master |
91c475c
to
5f68ee5
Compare
I have a merge up to do before you can retrieve your changes from 4.x. I'll do that shortly |
I made the merge |
46b0ba2
to
cdc7bd3
Compare
Rebased! |
Rebasing seem to toggle the colors of your user profile image 😄 |
The original profile picture was transparent and broke dark mode, I was waiting for someone @github to notice that transparent pictures may break with themes, unfortunately they didn't, so I had to revert :( 😊 |
@weirdan Can I let you merge that and update phpunit's baseline? |
@danog please rebase. I don't seem to be able to push to your branch: $ git push --force-with-lease
ERROR: Permission to zoonru/psalm.git denied to weirdan.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists. |
cdc7bd3
to
d0c9272
Compare
Done! |
Thanks! |
For feature parity with phpstan.
This PR kind of renders useless the
template_extended_count
property, replacing it with the more completetemplate_type_extends_count
, IDK if it's worth deprecating here and removing in v5.