Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate template_extended_count #7494

Merged
merged 2 commits into from Jan 26, 2022
Merged

Deprecate template_extended_count #7494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b30121b
Deprecate template_extended_count
danog Jan 26, 2022
d2d151c
Update baseline
danog Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions psalm-baseline.xml
View file
Open in desktop
Expand Up @@ -51,14 +51,16 @@
</PossiblyUndefinedIntArrayOffset>
</file>
<file src="src/Psalm/Internal/Analyzer/ClassAnalyzer.php">
<DeprecatedProperty occurrences="7">
<DeprecatedProperty occurrences="9">
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_minor_version</code>
<code>$codebase-&gt;php_minor_version</code>
<code>$codebase-&gt;php_minor_version</code>
<code>$storage-&gt;template_extended_count</code>
<code>$storage-&gt;template_extended_count</code>
</DeprecatedProperty>
<PossiblyUndefinedIntArrayOffset occurrences="3">
<code>$comments[0]</code>
Expand Down Expand Up @@ -501,7 +503,8 @@
</PossiblyUndefinedIntArrayOffset>
</file>
<file src="src/Psalm/Internal/PhpVisitor/Reflector/ClassLikeNodeScanner.php">
<DeprecatedProperty occurrences="2">
<DeprecatedProperty occurrences="3">
<code>$storage-&gt;template_extended_count</code>
<code>$this-&gt;codebase-&gt;php_major_version</code>
<code>$this-&gt;codebase-&gt;php_minor_version</code>
</DeprecatedProperty>
Expand Down
1 change: 1 addition & 0 deletions src/Psalm/Storage/ClassLikeStorage.php
View file
Open in desktop
Expand Up @@ -361,6 +361,7 @@ class ClassLikeStorage
public $template_extended_params;

/**
* @deprecated Will be replaced with $template_type_extends_count in Psalm v5
* @var ?int
*/
public $template_extended_count;
Expand Down