Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back empty keyword #7533

Merged
merged 1 commit into from Jan 30, 2022
Merged

add back empty keyword #7533

merged 1 commit into from Jan 30, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Jan 30, 2022

The keyword empty changed meaning in a previous PR that was replacing the empty type by never. It became an assertion type at this moment.

Assertion types were removed by Matt on his object assertion PR and he removed the empty keyword altogether.

If projects used the empty keyword, it would be a big break. This PR adds back empty as an alias for never

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 30, 2022
@orklah orklah merged commit 31941d1 into vimeo:master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant