Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backward compatibility check #7576

Merged
merged 1 commit into from Feb 4, 2022
Merged

Added backward compatibility check #7576

merged 1 commit into from Feb 4, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Feb 3, 2022

This PR adds an automated check to ensure we preserve backward compatibility during the 5.x release cycle. For now, checks are run on pull requests and only analyse changes in the pull request. Once we release a stable 5.x, we need to reconfigure it to also run it on pushes and to compare API to 5.0

Failure demo: https://github.com/vimeo/psalm/actions/runs/1792863207

@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Feb 3, 2022
@weirdan weirdan force-pushed the add-bcc branch 5 times, most recently from d79d775 to 0d5051a Compare February 3, 2022 23:32
@weirdan weirdan requested a review from orklah February 4, 2022 02:23
@weirdan weirdan marked this pull request as ready for review February 4, 2022 02:23
@weirdan weirdan merged commit 438a80d into vimeo:master Feb 4, 2022
@weirdan weirdan deleted the add-bcc branch February 4, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants