Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize issues #7595

Merged
merged 2 commits into from Feb 6, 2022
Merged

Finalize issues #7595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a331ac0
Finalize issues
weirdan Feb 5, 2022
aea950a
Update UPGRADING.md
weirdan Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
296 changes: 291 additions & 5 deletions UPGRADING.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Psalm/Issue/AbstractInstantiation.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class AbstractInstantiation extends CodeIssue
final class AbstractInstantiation extends CodeIssue
{
public const ERROR_LEVEL = 7;
public const SHORTCODE = 72;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/AbstractMethodCall.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class AbstractMethodCall extends CodeIssue
final class AbstractMethodCall extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 223;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/AmbiguousConstantInheritance.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class AmbiguousConstantInheritance extends ClassConstantIssue
final class AmbiguousConstantInheritance extends ClassConstantIssue
{
public const ERROR_LEVEL = 6;
public const SHORTCODE = 305;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ArgumentTypeCoercion.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ArgumentTypeCoercion extends ArgumentIssue
final class ArgumentTypeCoercion extends ArgumentIssue
{
public const ERROR_LEVEL = 3;
public const SHORTCODE = 193;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/AssignmentToVoid.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class AssignmentToVoid extends CodeIssue
final class AssignmentToVoid extends CodeIssue
{
public const ERROR_LEVEL = 7;
public const SHORTCODE = 121;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/CircularReference.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class CircularReference extends CodeIssue
final class CircularReference extends CodeIssue
{
public const ERROR_LEVEL = 7;
public const SHORTCODE = 131;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ComplexFunction.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ComplexFunction extends CodeIssue
final class ComplexFunction extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 259;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ComplexMethod.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ComplexMethod extends CodeIssue
final class ComplexMethod extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 260;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ConfigIssue.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ConfigIssue extends CodeIssue
final class ConfigIssue extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 271;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ConflictingReferenceConstraint.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ConflictingReferenceConstraint extends CodeIssue
final class ConflictingReferenceConstraint extends CodeIssue
{
public const ERROR_LEVEL = 7;
public const SHORTCODE = 85;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ConstructorSignatureMismatch.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ConstructorSignatureMismatch extends CodeIssue
final class ConstructorSignatureMismatch extends CodeIssue
{
public const ERROR_LEVEL = 5;
public const SHORTCODE = 231;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ContinueOutsideLoop.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ContinueOutsideLoop extends CodeIssue
final class ContinueOutsideLoop extends CodeIssue
{
public const ERROR_LEVEL = 7;
public const SHORTCODE = 43;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedClass.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedClass extends ClassIssue
final class DeprecatedClass extends ClassIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 98;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedConstant.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedConstant extends CodeIssue
final class DeprecatedConstant extends CodeIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 170;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedFunction.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedFunction extends FunctionIssue
final class DeprecatedFunction extends FunctionIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 201;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedInterface.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedInterface extends ClassIssue
final class DeprecatedInterface extends ClassIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 152;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedMethod.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedMethod extends MethodIssue
final class DeprecatedMethod extends MethodIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 1;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedProperty.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedProperty extends PropertyIssue
final class DeprecatedProperty extends PropertyIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 99;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DeprecatedTrait.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DeprecatedTrait extends CodeIssue
final class DeprecatedTrait extends CodeIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 171;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DocblockTypeContradiction.php
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@

use Psalm\CodeLocation;

class DocblockTypeContradiction extends CodeIssue
final class DocblockTypeContradiction extends CodeIssue
{
public const ERROR_LEVEL = 2;
public const SHORTCODE = 155;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateArrayKey.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateArrayKey extends CodeIssue
final class DuplicateArrayKey extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 151;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateClass.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateClass extends CodeIssue
final class DuplicateClass extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 71;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateConstant.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateConstant extends ClassIssue
final class DuplicateConstant extends ClassIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 302;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateEnumCase.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateEnumCase extends ClassIssue
final class DuplicateEnumCase extends ClassIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 277;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateEnumCaseValue.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateEnumCaseValue extends ClassIssue
final class DuplicateEnumCaseValue extends ClassIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 279;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateFunction.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateFunction extends CodeIssue
final class DuplicateFunction extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 180;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateMethod.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateMethod extends CodeIssue
final class DuplicateMethod extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 178;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/DuplicateParam.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class DuplicateParam extends CodeIssue
final class DuplicateParam extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 65;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/EmptyArrayAccess.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class EmptyArrayAccess extends CodeIssue
final class EmptyArrayAccess extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 100;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ExtensionRequirementViolation.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ExtensionRequirementViolation extends CodeIssue
final class ExtensionRequirementViolation extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 239;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/FalsableReturnStatement.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class FalsableReturnStatement extends CodeIssue
final class FalsableReturnStatement extends CodeIssue
{
public const ERROR_LEVEL = 5;
public const SHORTCODE = 137;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/FalseOperand.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class FalseOperand extends CodeIssue
final class FalseOperand extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 161;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ForbiddenCode.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ForbiddenCode extends CodeIssue
final class ForbiddenCode extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 2;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/IfThisIsMismatch.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class IfThisIsMismatch extends CodeIssue
final class IfThisIsMismatch extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 300;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImplementationRequirementViolation.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImplementationRequirementViolation extends CodeIssue
final class ImplementationRequirementViolation extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 240;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImplementedParamTypeMismatch.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImplementedParamTypeMismatch extends CodeIssue
final class ImplementedParamTypeMismatch extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 199;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImplementedReturnTypeMismatch.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImplementedReturnTypeMismatch extends CodeIssue
final class ImplementedReturnTypeMismatch extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 123;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImplicitToStringCast.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImplicitToStringCast extends CodeIssue
final class ImplicitToStringCast extends CodeIssue
{
public const ERROR_LEVEL = 4;
public const SHORTCODE = 60;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpureByReferenceAssignment.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpureByReferenceAssignment extends CodeIssue
final class ImpureByReferenceAssignment extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 220;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpureFunctionCall.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpureFunctionCall extends CodeIssue
final class ImpureFunctionCall extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 202;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpureMethodCall.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpureMethodCall extends CodeIssue
final class ImpureMethodCall extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 203;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpurePropertyAssignment.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpurePropertyAssignment extends CodeIssue
final class ImpurePropertyAssignment extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 204;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpurePropertyFetch.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpurePropertyFetch extends CodeIssue
final class ImpurePropertyFetch extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 234;
Expand Down
2 changes: 1 addition & 1 deletion src/Psalm/Issue/ImpureStaticProperty.php
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

namespace Psalm\Issue;

class ImpureStaticProperty extends CodeIssue
final class ImpureStaticProperty extends CodeIssue
{
public const ERROR_LEVEL = -1;
public const SHORTCODE = 221;
Expand Down