chore: enable psl tests again #7596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
force-pushed
the
chore/enable-psl
branch
from
851aab9
to
0abcc8f
Compare
|
test failure is correct, and this is the first psalm 5 bug discovered thanks to PSL :D
|
Was there since 4.6.3, but is a bug anyway. |
orklah
added
release:internal
orklah
approved these changes
Feb 11, 2022
|
I think we can merge that and baseline the error while waiting for the fix. @weirdan do you mind? |
azjezz
force-pushed
the
chore/enable-psl
branch
from
0abcc8f
to
89f2069
Compare
Signed-off-by: azjezz <azjezz@protonmail.com>
weirdan
force-pushed
the
chore/enable-psl
branch
from
89f2069
to
d47c014
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
released psalm-plugin 1.1.4, and 2.0.1 fixing compatibility with psalm 5.
I also rebased
psalm/endtoend-test-pslrepository on the latest 1.9.x changes ( which remove forbidEcho configuration entry )