Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config to define thread count (4.x) #7633

Merged
merged 4 commits into from Feb 11, 2022
Merged

Conversation

M1ke
Copy link
Contributor

@M1ke M1ke commented Feb 11, 2022

Applying the same commits from #7442 to the 4.x branch

@M1ke
Copy link
Contributor Author

M1ke commented Feb 11, 2022

As mentioned here (#7442 (comment)) if this gets merged to 4.x I am happy to resolve any conflicts with master, but I believe it should fit in directly.

@M1ke
Copy link
Contributor Author

M1ke commented Feb 11, 2022

I can see that the check ci/circleci: test-with-real-projects fails and it's hard to see what in this branch would cause this - nothing in this work would change how Psalm carries out its analysis, and it will only apply the thread limit if the config file is modified.

@orklah
Copy link
Collaborator

orklah commented Feb 11, 2022

failures in real projects are indeed unrelated :)

@orklah orklah added PR: Need review release:feature The PR will be included in 'Features' section of the release notes labels Feb 11, 2022
@orklah orklah merged commit 6e2efff into vimeo:4.x Feb 11, 2022
@orklah
Copy link
Collaborator

orklah commented Feb 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Need review release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants