New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize extension requirements in composer.json #7648

Draft

sasezaki wants to merge 3 commits into vimeo:master from sasezaki:composer_ext

Contributor

sasezaki commented Feb 12, 2022

continuation of #6844 and #7632.

Declare as "ext-filter" is require obviously.
Added ext-pcntl, ext-posix to composer.json suggest property.
- I added as "In order to run psalm-language-server". If it is not correct, please pointed it.
use PDOException literal instead of ::class to avoid taken as dependency
- composer-require-checker guessed dependency "ext-PDO". But only use of PDOException::class.

sasezaki added 3 commits

February 12, 2022 09:24


          Declare as ext-filter is require obvisioly

c21adbc


          Added ext-pcntl, ext-posix to composer.json suggest property

5d68760


          use PDOException literal instead of ::class to avoid taken as dependency

4e1c2bc

Collaborator

AndrolGenhald commented Feb 12, 2022

* Added ext-pcntl, ext-posix to composer.json suggest property.
  
  * I added as "In order to run psalm-language-server".  If it is not correct, please pointed it.

I believe they're used for "threads" to speed up analysis, I'm not sure if they're related to the language server or not.

sasezaki marked this pull request as draft

February 12, 2022 13:58

AndrolGenhald mentioned this pull request

PDOException extends RuntimeException and can use int code errors #7673

Merged

orklah added the PR: Needs work label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment