More attribute fixes.

[AndrolGenhald]

• Fix case where attributes from stubs don't match declarations in the code (fixes [Bug] RuntimeException Expected attribute count to match attribute storage count #7751)
• Fix returning function not analyzing attribute construction (fixes Enum cases are not validated in attribute if method return type is not void #7756)
• Use constants for attribute targets

AttributeStorage isn't really used anymore, but it's still around for plugins.

[AndrolGenhald]

Any idea what's up with the phar build? It doesn't seem related to this PR, but other recent PRs haven't had it fail.

Also, let me know when this is merged to master and I'll do another PR for class constant attributes. I figure it's easier to wait for Psalm 5 to do that since class const analysis changed significantly.

[orklah]

It has been broken for a few days. Symfony added a polyfill for PhpToken I believe and the Phar build doesn't like that. I haven't looked how to fix that for now

[orklah]

Thanks!

[orklah]

Oh, I think the phar build has been fixed by Matt in fact

[AndrolGenhald]

Oh, yeah, I see it, I didn't rebase on master before pushing so this PR is actually "older" than the other recent PRs, that explains it.