Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid json_encode when serializing non-UTF8 literals #7791

Merged
merged 3 commits into from Mar 16, 2022
Merged

Avoid json_encode when serializing non-UTF8 literals #7791

merged 3 commits into from Mar 16, 2022

Commits on Mar 15, 2022

  1. Add test case reproducing issue vimeo#7771 

    Related: vimeo#7771
    @ohader
    ohader committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    b00d9e9 View commit details
    Browse the repository at this point in the history

  2. Avoid json_encode when serializing non-UTF8 literals 

    `\Psalm\Internal\Clause::$hash` basically holds a hash on
arbitrary input literals, used for later comparison. Using
`json_encode` fails when dealing with non-UTF8 literals,
which has been replaced by plain PHP `serialize`.

Resolves: vimeo#7771
    @ohader
    ohader committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    2b37536 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Adjust test case format 

    Related: vimeo#7771
    @ohader
    ohader committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    9e4e468 View commit details
    Browse the repository at this point in the history