igbinary_serialize code was missing in file #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
add-missing-igbinary-serialize-code
branch
2 times, most recently
from
71b3843
to
6bf38dc
Compare
kkmuffme
force-pushed
the
add-missing-igbinary-serialize-code
branch
from
6bf38dc
to
ed0db0f
Compare
|
The line length limit of 120 is excessively low and just a waste of time. Added a bug 3 times in the perfectly valid code, due to this. Code readability is worse too. |
|
Yeah, I tend to use 150 for my own stuff these days. At least it's not the historic limit of 80... Maybe start a discussion about changing it to get everyone's input? |
AndrolGenhald
added
the
release:internal
|
Could someone merge this? |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason igbinary code was missing in a single file. Added it now.
Fixes #8006