Improve handling of unsupported references (fixes #8018). #8022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrolGenhald
commented
May 26, 2022
Comment on lines
+978
to
+985
| if (!$stmt->var instanceof ArrayDimFetch && !$stmt->var instanceof PropertyFetch) { | ||
| // If left-hand-side is an array offset or object property, usage is too difficult to track, | ||
| // so it's not registered as an unused variable (this mirrors behavior for non-references). | ||
| $statements_analyzer->registerVariableAssignment( | ||
| $lhs_var_id, | ||
| $lhs_location | ||
| ); | ||
| } |
There was a problem hiding this comment.
It turns out the bug this pull request fixes actually affected this method, causing everything after $context->vars_in_scope[$lhs_var_id] = &$context->vars_in_scope[$rhs_var_id]; to be ignored.
After it was fixed, that same line was reported as an unused variable, so I finally gave up and just decided that putting a reference in an object or an array is a bad idea anyway, and it's not worth it to track usage in that case (this is basically increasing the scope of the change in #7684 from only ignoring unused references on $this to ignoring unused references on any object or array).
AndrolGenhald
added
the
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the reference analysis to report references it's unable to analyze and continue as if they weren't references, rather than aborting analysis altogether.