Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various array spread issues. #8044

Merged
merged 4 commits into from Jul 26, 2022
Merged

Fix various array spread issues. #8044

merged 4 commits into from Jul 26, 2022

Commits on Jul 26, 2022

  1. Fix various array spread issues. 

     - Correctly infer `array` and `list` instead of `non-empty-array` and `non-empty-list` (fixes vimeo#7296)
 - Add support for spreading string keys (fixes vimeo#7297).
 - Show issue when trying to unpack non-iterable
 - Show issue when trying to unpack iterable with non-array-key key
 - Re-added invalid PHP 8.0 tests removed in vimeo#6613
 - Unpacked lists with known keys will be inferred as eg `array{0: int, 1: int}<int<0, max>, int>` now but will still be treated as lists
 - Unpacked arrays with known keys will now be inferred as eg `array{a: string, b: string}<int, int>` instead of `array<int|string, int|string>`
    @AndrolGenhald
    AndrolGenhald committed Jul 26, 2022
    Copy the full SHA
    d54eebf View commit details
    Browse the repository at this point in the history

  2. Use count instead of empty.

    @AndrolGenhald
    AndrolGenhald committed Jul 26, 2022
    Copy the full SHA
    2b389df View commit details
    Browse the repository at this point in the history

  3. Fix key comparison when unpacking Traversables.

    @AndrolGenhald
    AndrolGenhald committed Jul 26, 2022
    Copy the full SHA
    ee68184 View commit details
    Browse the repository at this point in the history

  4. Fix array-shape value type being mixed instead of single key being mi… 

    …xed.
    @AndrolGenhald
    AndrolGenhald committed Jul 26, 2022
    Copy the full SHA
    094621d View commit details
    Browse the repository at this point in the history