Simplify ForeachAnalyzer::getKeyValueParamsForTraversableObject.
#8052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly infer `array` and `list` instead of `non-empty-array` and `non-empty-list` (fixes vimeo#7296) - Add support for spreading string keys (fixes vimeo#7297). - Show issue when trying to unpack non-iterable - Show issue when trying to unpack iterable with non-array-key key - Re-added invalid PHP 8.0 tests removed in vimeo#6613 - Unpacked lists with known keys will be inferred as eg `array{0: int, 1: int}<int<0, max>, int>` now but will still be treated as lists - Unpacked arrays with known keys will now be inferred as eg `array{a: string, b: string}<int, int>` instead of `array<int|string, int|string>`
AndrolGenhald
added
release:internal
|
@AndrolGenhald the blocker is no longer blocking. Should we merge this after conflicts are resolved? |
|
I'll take a look at it soon, I think this was a pretty good simplification reusing other code instead of duplicating a bunch of complicated functionality, so as long as the tests pass it should be ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8044.