Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: allow non-union assertion types #8077

Merged
merged 18 commits into from Jun 27, 2022
Merged

Feature: allow non-union assertion types #8077

merged 18 commits into from Jun 27, 2022

Commits on Jun 8, 2022

  1. qa: add failing test for one-of assertion 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 8, 2022
    Copy the full SHA
    a9daa3b View commit details
    Browse the repository at this point in the history

  2. bugfix: allow non-single union types in assertions 

    fixes vimeo#5657

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 8, 2022
    Copy the full SHA
    40971ff View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. bugfix: only override templated values in case of literals 

    This will avoid issues with invalid intersection assertions.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    7c85e0c View commit details
    Browse the repository at this point in the history

  2. bugfix: overriding types based on assertions have to pass more checks 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    2d9133b View commit details
    Browse the repository at this point in the history

  3. bugfix: only extend existing logic instead of hijacking it 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    4ee1b3f View commit details
    Browse the repository at this point in the history

  4. bugfix: only allow narrowing down types in case the old type is not s… 

    …ingle

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    c68b6e9 View commit details
    Browse the repository at this point in the history

  5. qa: ensure we use multiple isset to verify the existence of `$arg_v… 

    …ar_id`

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    6c1ed90 View commit details
    Browse the repository at this point in the history

  6. qa: use $assertion_var_id over $arg_var_id for better type reflec… 

    …tion

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 11, 2022
    Copy the full SHA
    e13268f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. feature: add Union#allFloatLiterals as it was missing 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    4068f5c View commit details
    Browse the repository at this point in the history

  2. bugfix: tighten the detection of types which narrow down other types 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    6a73fbd View commit details
    Browse the repository at this point in the history

  3. qa: add more specific unit test(s) for the oneOf detection 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    083da24 View commit details
    Browse the repository at this point in the history

  4. qa: use dedicated variable for asserting a specific value 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    92b4bf1 View commit details
    Browse the repository at this point in the history

  5. feature: add more accurate equals checks for TLiteralFloat, `TLit… 

    …eralInt` and `TLiteralString`

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    02d4f0c View commit details
    Browse the repository at this point in the history

  6. bugfix: in case the old type is already more accurate than the new ty… 

    …pe, do not consider the new type as a replacement

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    ed1bb8a View commit details
    Browse the repository at this point in the history

  7. bugfix: do not extend the type - only narrow down 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    7e033d8 View commit details
    Browse the repository at this point in the history

  8. qa: refactor code to avoid too many nesting levels 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    3fd7a8b View commit details
    Browse the repository at this point in the history

  9. bugfix: single does not mean that only one single atomic type is st… 

    …ored within a union

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 12, 2022
    Copy the full SHA
    0d96766 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. qa: drop unnecessary ensure_source_equality check 

    Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
    @boesing
    boesing committed Jun 27, 2022
    Copy the full SHA
    df927d0 View commit details
    Browse the repository at this point in the history