Change return type of createFromInterface() on DateTime and DateTimeImmutable to static #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateTime and DateTimeImmutable to 'static' so extending classes are recognized.
AndrolGenhald
added
the
release:fix
|
@weirdan Mind looking at this? I vaguely remember there is some mumbo jumbo around DateTime that you warned about some time ago |
|
Just to be clear, I've tested that the The reason I came accross this, is because it also messes with the Carbon package, commonly used in Laravel, for example. |
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release:fix: Change return type of
createFromInterface()methods onDateTimeandDateTimeImmutabletostaticso extending classes are recognized.Also fixed a test that was based on the incorrect return type.
Fixes #8096