Update DOM stub and add separate SimpleXML stub #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrolGenhald
commented
Jun 22, 2022
|
|
||
| public function valid(): bool {} | ||
|
|
||
| public function current(): SimpleXMLIterator {} |
There was a problem hiding this comment.
Technically incorrect, it can return null until PHP 8.1, but I don't think calling current() directly is very common, so it's probably preferable to trade the very uncommon false negative for much more common false positives.
Related to php/doc-en#1640
AndrolGenhald
commented
Jun 22, 2022
Comment on lines
-939
to
+941
| foreach ($xml->children() as $img) { | ||
| $children = $xml->children(); | ||
| assert($children !== null); | ||
| foreach ($children as $img) { |
There was a problem hiding this comment.
This was a false negative: https://3v4l.org/rqvMc
Merged
AndrolGenhald
added
the
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.