Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReflectionProperty properties #8148

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

BenMorel
Copy link
Contributor

@BenMorel
Copy link
Contributor Author

I noticed other classes that are missing properties, I'll probably take care of them as well in another PR. Question: in the case of ReflectionFunction::$name, inherited from ReflectionFunctionAbstract, do I need to put the property in both classes? If I'm not mistaken, this is the case with the CallMap.

@orklah
Copy link
Collaborator

orklah commented Jun 23, 2022

I would not expect it to be needed, otherwise we would have every standard exception in here too but I'm not certain. Could you take a look at CI failures? Looks like some casts became unnecessary after your changes

@BenMorel
Copy link
Contributor Author

@orklah Done!

I'l take care of other properties in another PR then 👍

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jun 24, 2022
@orklah orklah merged commit d626d24 into vimeo:4.x Jun 24, 2022
@orklah
Copy link
Collaborator

orklah commented Jun 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants