Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_* function signatures #8151

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

othercorey
Copy link
Contributor

@othercorey othercorey commented Jun 23, 2022

array_replace historically could return null on a type error, but that didn't seem like a worthwhile edge case to add. It should always return an array and since 8.0 will always return an array.

@othercorey
Copy link
Contributor Author

Looks like a few other functions were changed to allow optional arguments, but I have to figure out when they changed since it's not documented.

@othercorey othercorey force-pushed the fix-array-sigs branch 2 times, most recently from f443f62 to dfe8910 Compare June 23, 2022 22:34
@AndrolGenhald
Copy link
Collaborator

but I have to figure out when they changed since it's not documented.

You can go ahead an open an issue for https://github.com/php/doc-en for that.

@AndrolGenhald AndrolGenhald added the release:fix The PR will be included in 'Fixes' section of the release notes label Jun 24, 2022
@othercorey
Copy link
Contributor Author

You can go ahead an open an issue for https://github.com/php/doc-en for that.

I submitted patches for missing documentation.

Looks like array_replace $replacements was always optional so that should be the last fix.

@orklah orklah merged commit 9b4c8cb into vimeo:4.x Jun 24, 2022
@orklah
Copy link
Collaborator

orklah commented Jun 24, 2022

Thanks for your work on that! That's great!

@othercorey othercorey deleted the fix-array-sigs branch June 24, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants