Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if propagation #8326

Merged
merged 6 commits into from Jul 30, 2022
Merged

Fix if propagation #8326

merged 6 commits into from Jul 30, 2022

Conversation

danog
Copy link
Collaborator

@danog danog commented Jul 28, 2022

Fixes #8317

@danog danog changed the title Add failing unit test Fix if propagation Jul 28, 2022
@danog
Copy link
Collaborator Author

danog commented Jul 28, 2022

This reverts what is essentially a simplification of if handling logic, since the old logic allowed for patterns that aren't that uncommon in real code (an example is included in a new testcase).

@danog danog marked this pull request as ready for review July 28, 2022 11:00
@orklah
Copy link
Collaborator

orklah commented Jul 28, 2022

@muglug could you take a look at #8317 please? Maybe there's an easier fix rather than reverting the whole thing?

Copy link
Collaborator

@muglug muglug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! At some point I might try to figure out a solution that works with else if, and the nested of example I gave, but for now I’m happy to revert my change.

@muglug muglug merged commit 24f7920 into vimeo:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants