fix: Fix parsing of invalid intersection types #8385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns `TNever` for an intersection of 2 non-overlapping named classes instead of throwing an exception. Will raise a new `InvalidIntersectionType` in the case that this is detected. Psalm will now also raise a parse error instead of throwing if it cannot deduce the resolved intersection type. Resolves vimeo#8333
danog
changed the title
|
Well, the question is, does If it can happen, it would definitely mean a InvalidIntersectionType should be emitted and your change would not do that. If it can't happen then yeah, we should try to keep consistency. |
|
All fixed! |
|
Actually nevermind, it seems like there's a bug in the InArray assertion reconciler |
weirdan
reviewed
Dec 3, 2022
Comment on lines
+546
to
+547
| Union $type_1, | ||
| Union $type_2, |
There was a problem hiding this comment.
Do we really need this BC break here? This is a part of our API surface, so the earliest it can change is in Psalm 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8333 properly, replacing #8384.
I feel that we need to be consistent with the return type of
Type::intersectUnionTypes: if there is no possible intersection between the types, return null, otherwise return a Union with the types.The previous PR incorrectly returned TNever only for certain invalid intersections: if we really want to go with that approach, then let's always return either a Union or a Union(TNever), and never
null(but I would personally leave it as it is right now, as it's easier to tell if there's no intersection between the types this way).