Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed type hole when sending Foo<string> to Foo<mixed> #8481

Merged
merged 4 commits into from Sep 13, 2022

Conversation

muglug
Copy link
Collaborator

@muglug muglug commented Sep 13, 2022

This fixes a minor type hole that allowed mixed and array-key to bypass variance checks.

@muglug muglug added the release:fix The PR will be included in 'Fixes' section of the release notes label Sep 13, 2022
@muglug muglug merged commit d957ff2 into vimeo:master Sep 13, 2022
@muglug muglug deleted the muglug-fix-mixed-type-hold branch September 13, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant