-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More specific superglobals feedback update #8561
Merged
orklah
merged 7 commits into
vimeo:4.x
from
kkmuffme:more-specific-superglobals-feedback-update
Oct 10, 2022
Merged
More specific superglobals feedback update #8561
orklah
merged 7 commits into
vimeo:4.x
from
kkmuffme:more-specific-superglobals-feedback-update
Oct 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
approved these changes
Oct 10, 2022
@@ -719,6 +723,9 @@ public static function getGlobalType(string $var_id, int $codebase_analysis_php_ | |||
'HTTP_SEC_CH_UA_PLATFORM' => $non_empty_string_helper, | |||
'HTTP_SEC_CH_UA_MOBILE' => $non_empty_string_helper, | |||
'HTTP_SEC_CH_UA' => $non_empty_string_helper, | |||
// phpunit | |||
'APP_DEBUG' => $bool_string_helper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record
- Phpunit cast
'false'
and'true'
to a boolean. - Symfony support using
APP_DEBUG=0
orAPP_DEBUG=1
in the .env file.
So the best way to represent this is bool|string and force people to cast to bool.
orklah
added
the
release:fix
The PR will be included in 'Fixes' section of the release notes
label
Oct 10, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8559
Fix #8556
I think the
$_FILES
superglobal type is correct now, but absolute crap due to #8516Ideally we would have 4 distinct array types for it like:
Feel free to make any changes necessary before merging, I won't have time until next weekend though.