Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callmap for DOMNode methods #8566

Merged
merged 1 commit into from Oct 11, 2022

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Oct 11, 2022

No description provided.

@tvdijen tvdijen changed the base branch from 4.x to master October 11, 2022 11:11
@orklah
Copy link
Collaborator

orklah commented Oct 11, 2022

Hey! Can you rebase? The CI crashed somehow.

Would you have an example for lookupNamespaceUri taking null and returning null on strict_types? Seems different than the official doc

@tvdijen
Copy link
Contributor Author

tvdijen commented Oct 11, 2022

The docs are a total mess. Especially on the DOM-extension. For some reason they won't merge doc updates, so I gave up on that a long time ago.

Let me point you to the DOM specs:
https://www.w3.org/TR/DOM-Level-3-Core/core.html#Node3-lookupNamespaceURI

As well as the PHP source:
https://github.com/php/php-src/blob/master/ext/dom/node.c#L1513-L1518

Passing null to lookupNamespaceURI means to lookup the default namespace.
If no default namespace exists, this method will return null.

For lookupPrefix, if it cannot be found the method will return null.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Oct 11, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 11, 2022

That explanation will do just fine :) Thanks for the fix!

@orklah orklah merged commit eb6a347 into vimeo:master Oct 11, 2022
@tvdijen tvdijen deleted the bugfix/lookupNamespaceURI branch October 12, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants