check "never" return type more strictly #8599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kkmuffme
commented
Oct 17, 2022
•
kkmuffme
commented
- require explicit "never" return type when function always exits
- error if function does not exit, but return type explicitly contains "never"
- Fix: Missing InvalidReturnType check when exit; #8175
- Fix: InvalidReturnType due to void and null not treated the same #8178
kkmuffme
force-pushed
the
check-never-return-more-strictly
branch
2 times, most recently
from
3b3cf85
to
aa9f4dc
Compare
|
I'm sure this will cause some followup issues to be created at some point in the future with PHP 8.1+, but I'll fix those once they actually pop up (and not for some synthetic examples we make up now) |
kkmuffme
force-pushed
the
check-never-return-more-strictly
branch
3 times, most recently
from
975dbb6
to
c64c4ac
Compare
|
I'm not sure I followed the actual changes yet. However, a few points first:
|
|
I need to wait until v5 is released before I can provide a PR on master/v5 branch, so we'll just put it on hold until then I guess |
|
You can already retarget it on master right now :) |
|
I can't bc we use this PR internally in our CI |
* require explicit "never" return type when function always exits * error if function does not exit, but return type explicitly contains "never" * Fix: vimeo#8175
previous PHP versions could give a fatal error in some cases, e.g. https://3v4l.org/ZRZZE
as this function needs a complete overhaul at some point in v5 - not doing this now, as it will just create conflicts with v5
kkmuffme
force-pushed
the
check-never-return-more-strictly
branch
from
520d9d0
to
81804bb
Compare
|
v5 see #8624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.