Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basename return type provider #8620

Merged
merged 1 commit into from Oct 26, 2022

Conversation

kkmuffme
Copy link
Contributor

Like dirname return type provider of #8611

Like dirname return type provider of vimeo#8611
@kkmuffme kkmuffme force-pushed the basename-return-type-provider branch from 7ef2cfb to 87eb836 Compare October 26, 2022 11:03
@kkmuffme
Copy link
Contributor Author

CI error is unrelated and already fixed in #8619

Please review & merge

@kkmuffme kkmuffme marked this pull request as ready for review October 26, 2022 11:11
@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Oct 26, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 26, 2022

Thanks!

@orklah orklah merged commit 26c2539 into vimeo:master Oct 26, 2022
@kkmuffme kkmuffme deleted the basename-return-type-provider branch December 1, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants