Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webmozart/pathUtil #8629

Closed
wants to merge 1 commit into from
Closed

Conversation

VincentLanglet
Copy link
Contributor

Backport of #7292

@orklah
Copy link
Collaborator

orklah commented Oct 29, 2022

In my memories, the suggestion was to use FileSystem from version 5.4. Unfortunately, version 5.4 does not support PHP 7.1 that we need to support on Psalm 4.

In this PR, you allowed FileSystem from 4.4 which supports PHP from 7.1.3.

So two things:

  • Is FileSystem 4.4 actually OK for the purpose here? I don't think we have anything running on 7.1 on CI so it may not be checked.
  • dependancies won't be able to be solved under 7.1.3, we should probably directly change that in composer.json for clarity

@VincentLanglet
Copy link
Contributor Author

In my memories, the suggestion was to use FileSystem from version 5.4. Unfortunately, version 5.4 does not support PHP 7.1 that we need to support on Psalm 4.

In this PR, you allowed FileSystem from 4.4 which supports PHP from 7.1.3.

So two things:

  • Is FileSystem 4.4 actually OK for the purpose here? I don't think we have anything running on 7.1 on CI so it may not be checked.
  • dependancies won't be able to be solved under 7.1.3, we should probably directly change that in composer.json for clarity

You're right, it was only introduce in SF 5.4, which only supports php >=7.2.5.

Should I close the PR or is it an ok thing to bump the dependencies/php version given the fact that

@VincentLanglet VincentLanglet marked this pull request as draft October 29, 2022 10:17
@orklah
Copy link
Collaborator

orklah commented Oct 29, 2022

Ideally, Psalm 4 should be EOL and replaced by Psalm 5. It should have already been released but my inexperience shows too much :p . Right now I'm just waiting for the end of the immutable PR and I'll ship it. Psalm 4 should stay as well in the meantime I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants